Modify

Ticket #522 (closed Bug: Will Not Fix)

Opened 2 years ago

Last modified 18 months ago

tiny bug in entrance_edit

Reported by: buergi Owned by:
Priority: Minor Milestone:
Component: entrance Keywords:
Cc: Blocked By:
Blocking:

Description (last modified by buergi) (diff)

The is a minor bug in entrance_edit which makes it impossible to use the --file command line switch:

@@ -26,7 +26,7 @@
 fi
 
 case $1 in
-       -c|--file) $DB=$2; shift; shift
+       -c|--file) DB=$2; shift; shift
        ;;
        -h) usage 0; shift
        ;;
@@ -38,7 +38,7 @@
 
 if [ -z "$1" ]; then ecore_config -a -c "$DB"; exit 0; fi
 
-type="$(ecore_config -a -c /etc/entrance_config.cfg | grep $1 | awk '{print $2}')"
+type="$(ecore_config -a -c "$DB" | grep $1 | awk '{print $2}')"
 if [ "$type" = "integer" ]; then
        type="i"
 elif [ "$type" = "string" ]; then

Attachments

Change History

comment:1 Changed 2 years ago by buergi

  • Description modified (diff)

comment:2 Changed 2 years ago by buergi

actually it would be even better to additionally change the third line to DB="@prefix@/etc/entrance_config.cfg" rename the file to entrance_edit.in and add it to AC_OUTPUT array in configure.ac so that the configuration file path would always match to entrance's.

comment:3 Changed 21 months ago by vtorri

can you write a patch for the last improvements you mentioned ?

comment:4 Changed 18 months ago by vtorri

  • Status changed from new to closed
  • Resolution set to Will Not Fix

Entrance is dead, use Elsa instead

View

Add a comment

Modify Ticket

Action
as closed
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.